ACTS TF: compute shared hits

Separates out measurementContainerOffsets() and measurementOffsets() from ActsTrk::detail::TrackFindingMeasurements into a new class ActsTrk::detail::SharedHitCounter.

• This class needs the hits provided with its own addMeasurements()
• It provides a method computeSharedHits() to record shared hits in a newly created track. This is used by TrackFindingAlg and TrackExtensionAlg to add shared hit flags to their output tracks.
• As a by-product, also provides method measurementIndex(hit), which is a unique hit index that is printed by TrackStatePrinter.

added ACTS label

marked this merge request as draft

This merge request affects 1 package:

• Tracking/Acts/ActsTrackReconstruction

This merge request affects 2 files:

• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.cxx
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.h

Adding @jojungge ,@tbold ,@goetz ,@cvarni ,@pagessin ,@adye ,@toyamaza as watchers

added Tracking main review-pending-level-1 labels

added 1 commit

• 82c1804b - fix comments

Compare with previous version

CI Result FAILURE (hash ee558ae6)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added 1 commit

• f25f56c4 - MR comments

Compare with previous version

added 1 commit

• a2dea921 - Added measurements.measurementIndex(measurement), which should now work with cache

Compare with previous version

Jenkins please retry a build

This merge request affects 1 package:

• Tracking/Acts/ActsTrackReconstruction

This merge request affects 10 files:

• Tracking/Acts/ActsTrackReconstruction/src/TrackExtensionAlg.cxx
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.cxx
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.h
• Tracking/Acts/ActsTrackReconstruction/src/TrackStatePrinterTool.cxx
• Tracking/Acts/ActsTrackReconstruction/src/TrackStatePrinterTool.h
• Tracking/Acts/ActsTrackReconstruction/src/TrackStatePrinterTool.icc
• Tracking/Acts/ActsTrackReconstruction/src/detail/TrackFindingMeasurements.cxx
• Tracking/Acts/ActsTrackReconstruction/src/detail/TrackFindingMeasurements.h
• Tracking/Acts/ActsTrackReconstruction/src/detail/TrackFindingMeasurements.icc
• Tracking/Acts/ActsTrackReconstruction/test/TrackFindingMeasurementsTest.cxx

Adding @tbold ,@goetz ,@pagessin ,@adye ,@toyamaza ,@cvarni ,@jojungge as watchers

removed review-pending-level-1 label

CI Result FAILURE (hash a2dea921)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added 1 commit

• 9326304d - separate out measurementIndex etc into new class, SharedHitCounter (it doesn't...

Compare with previous version

added 1 commit

• 0cf81da1 - tidy

Compare with previous version

added 3 commits

• f1428fd2 - move computeSharedHits into SharedHitCounter
• 9ee09ead - computeSharedHits called for each new track immediately after selection
• f6b0c9a5 - fix init test. 2 vectors -> vector<TrackStateIndex>

Compare with previous version

Jenkins please retry a build

This merge request affects 1 package:

• Tracking/Acts/ActsTrackReconstruction

This merge request affects 13 files:

• Tracking/Acts/ActsTrackReconstruction/src/TrackExtensionAlg.cxx
• Tracking/Acts/ActsTrackReconstruction/src/TrackExtensionAlg.h
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.cxx
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.h
• Tracking/Acts/ActsTrackReconstruction/src/TrackStatePrinterTool.cxx
• Tracking/Acts/ActsTrackReconstruction/src/TrackStatePrinterTool.h
• Tracking/Acts/ActsTrackReconstruction/src/TrackStatePrinterTool.icc
• Tracking/Acts/ActsTrackReconstruction/src/detail/SharedHitCounter.h
• Tracking/Acts/ActsTrackReconstruction/src/detail/SharedHitCounter.icc
• Tracking/Acts/ActsTrackReconstruction/src/detail/TrackFindingMeasurements.cxx
• Tracking/Acts/ActsTrackReconstruction/src/detail/TrackFindingMeasurements.h
• Tracking/Acts/ActsTrackReconstruction/src/detail/TrackFindingMeasurements.icc
• Tracking/Acts/ActsTrackReconstruction/test/TrackFindingMeasurementsTest.cxx

Adding @goetz ,@cvarni ,@toyamaza ,@adye ,@jojungge ,@pagessin ,@tbold as watchers

CI Result FAILURE (hash f6b0c9a5)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output (remote access info)

added 1 commit

• 5cbd446a - tidy up and fix unit test

Compare with previous version

resolved all threads

added 1 commit

• e67354a7 - update refs

Compare with previous version

@adye after implementing this do you think this can / should be generalized into an ACTS tool / utility function?

marked this merge request as ready

changed the description

build area is cleaned as the previous build was for the MR labeled as full-build

This merge request affects 2 packages:

• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsTrackReconstruction

Affected files list will not be printed in this case

Adding @cvarni ,@toyamaza ,@adye ,@goetz ,@jojungge ,@pagessin ,@tbold as watchers

added review-pending-level-1 label

CI Result FAILURE (hash e67354a7)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output (remote access info)

added 2 commits

• 32f45b20 - rename variable, and improve comments
• aac7f179 - fix unit test

Compare with previous version

This merge request affects 2 packages:

• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsTrackReconstruction

Affected files list will not be printed in this case

Adding @cvarni ,@tbold ,@toyamaza ,@pagessin ,@goetz ,@jojungge ,@adye as watchers

added 1 commit

• e88434b2 - fix ATLAS coding standards warning

Compare with previous version

This merge request affects 2 packages:

• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsTrackReconstruction

Affected files list will not be printed in this case

Adding @goetz ,@toyamaza ,@tbold ,@adye ,@cvarni ,@pagessin ,@jojungge as watchers

CI Result SUCCESS (hash aac7f179)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output (remote access info)

CI Result FAILURE (hash e88434b2)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Unresolved threads/test failure, L1

added review-user-action-required label and removed review-pending-level-1 label

The failure is in a (new?) test, CITest_ACTS_ActsBenchmarkWithSpotHeavyIons-test. The problem is a crash in the code, seemingly unrelated to this MR. Let me first retry the build before asking further.

Jenkins please retry a build

This merge request affects 2 packages:

• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsTrackReconstruction

Affected files list will not be printed in this case

Adding @pagessin ,@jojungge ,@toyamaza ,@cvarni ,@goetz ,@adye ,@tbold as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash e88434b2)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Still unresolved threads , L1

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

removed review-user-action-required label