Skip to content
Snippets Groups Projects

adding minET parameters to Topo ADVAE algorithm

Merged Ralf Gugel requested to merge rgugel/athena:topoADminEtParameters into 24.0
All threads resolved!

This MR adds some more L1Menu configurable parameters to the newly introduced AnomalyDetection algorithm on L1Topo.

The purpose of these parameters is to have ET cut capabilities inside this algorithm similar to other decision algorithms in L1Topo. For the AD algorithm this may become particularly relevant as the underlying NN is trained on previously taken data and thus is likely to have learned artificial features such as existing ET cuts applied before L1Topo (e.g. jFEX currently applies a 15 GeV cut on jJets for both, sending them to L1Topo which also reflects in the contents of the RoI readout data that is effectively what the NN sees during training - as the NN have never seen a 12 GeV jJet during its training the occurrence of such an object would seem highly "anomalous").

If those thresholds were to be lowered for the benefit of other signatures/algorithms the AD algo may likely create a much higher trigger rate unless we ensure that at least we can independently keep consistent minET thresholds for the AD algorithm (increasing thresholds upstream of L1Topo is not addressed here but may have less severe implications and also does not seem realistic to be desirable for the remainder of Run 3).

Related jira ticket: https://its.cern.ch/jira/browse/ATR-30618

Edited by Ralf Gugel

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Petar BokanPetar Bokan 3 weeks ago (Jan 31, 2025 12:42pm UTC)

Merge details

  • Changes merged into 24.0 with f7ae13a6 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ralf Gugel added 1 commit

    added 1 commit

    Compare with previous version

  • Ralf Gugel resolved all threads

    resolved all threads

  • Ralf Gugel added 1 commit

    added 1 commit

    Compare with previous version

  • Ralf Gugel marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 2 packages:

    • Trigger/TrigT1/L1Topo/L1TopoAlgorithms
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @iriu ,@stelzer ,@asonay ,@oliveirg ,@orlando ,@sutt ,@jmharris ,@lidiaz ,@paulama ,@shanisch ,@cmorenom as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 132K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDef.py

  • :white_check_mark: CI Result SUCCESS (hash 1c5a1e0f)

    Athena DetCommon
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Ralf Gugel changed the description

    changed the description

  • discussed offline, good to go from the menu side.

  • Petar Bokan mentioned in commit f7ae13a6

    mentioned in commit f7ae13a6

  • merged

  • Tadej Novak mentioned in merge request !77618 (merged)

    mentioned in merge request !77618 (merged)

  • Please register or sign in to reply
    Loading