Skip to content
Snippets Groups Projects

Fix to EgammaTruthxAODHelpers

Merged Andrii Verbytskyi requested to merge averbyts/athena:egammatruthxaod into main
All threads resolved!

Fix to EgammaTruthxAODHelpers: check if all the parents of particle are gamma or e. The previous version was checking only the first parent.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Andrii Verbytskyi resolved all threads

    resolved all threads

  • added 1 commit

    • e23d4275 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Thank you, @tstreble !

  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • This merge request affects 1 package:

    • Event/xAOD/xAODEgamma

    This merge request affects 1 file:

    • Event/xAOD/xAODEgamma/Root/EgammaTruthxAODHelpers.cxx

    Adding @akraszna as watcher

  • :x: CI Result FAILURE (hash e23d4275)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • Event/xAOD/xAODEgamma

    This merge request affects 1 file:

    • Event/xAOD/xAODEgamma/Root/EgammaTruthxAODHelpers.cxx

    Adding @akraszna as watcher

  • :white_check_mark: CI Result SUCCESS (hash e23d4275)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Changes are fine and CI succeeds, approving for L1. -L1

  • Approving, Marco (AR shifter)

  • mentioned in commit eb96daac

  • Please register or sign in to reply
    Loading