Skip to content
Snippets Groups Projects

CP algorithms: Fix electron trigger scale factors

Merged Tadej Novak requested to merge tadej/athena:cp-el-sf into main

Fix electron trigger scale factors as some incorrect assumptions were made. Now the global trigger SF tool helper functions are used to find sensible keys.

Help with testing would be appreciated.

/cc @jmaurer @ravinab @tstreble @ztao

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tadej Novak added 1 commit

    added 1 commit

    • 29bb5726 - CP algorithms: Fix electron trigger scale factors

    Compare with previous version

  • Julien Maurer resolved all threads

    resolved all threads

    • Resolved by Tadej Novak

      Ok with some MC23, I get the following crash.

      TrigGlobalEffic...  ERROR Invalid format for the trigger combination ''
      Traceback (most recent call last):
        File "/atlas/strebler/HHbbtautau/EleTrig/build/x86_64-el9-gcc13-opt/bin/bbtt-ntupler", line 122, in <module>
          is_successful = main()
                          ^^^^^^
        File "/atlas/strebler/HHbbtautau/EleTrig/build/x86_64-el9-gcc13-opt/bin/bbtt-ntupler", line 103, in main
          cfg, flags, args = bbtt_job_cfg()
                             ^^^^^^^^^^^^^^
        File "/atlas/strebler/HHbbtautau/EleTrig/build/x86_64-el9-gcc13-opt/bin/bbtt-ntupler", line 42, in bbtt_job_cfg
          cfg = default_sequence_cfg(flags, seqname)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/atlas/strebler/HHbbtautau/EleTrig/build/x86_64-el9-gcc13-opt/python/EasyjetHub/steering/main_sequence_config.py", line 39, in default_sequence_cfg
          cfg.merge(event_building_cfg(flags, seqname))
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/atlas/strebler/HHbbtautau/EleTrig/build/x86_64-el9-gcc13-opt/python/EasyjetHub/steering/main_sequence_config.py", line 160, in event_building_cfg
          cfg.merge(cpalgs_cfg(flags), seqname)
                    ^^^^^^^^^^^^^^^^^
        File "/atlas/strebler/HHbbtautau/EleTrig/build/x86_64-el9-gcc13-opt/python/EasyjetHub/algs/cpalgs_config.py", line 192, in cpalgs_cfg
          configSeq.fullConfigure(configAccumulator)
        File "/cvmfs/atlas.cern.ch/repo/sw/software/25.2/AthAnalysis/25.2.39/InstallArea/x86_64-el9-gcc13-opt/python/AnalysisAlgorithmsConfig/ConfigSequence.py", line 137, in fullConfigure
          self.makeAlgs (config)
        File "/cvmfs/atlas.cern.ch/repo/sw/software/25.2/AthAnalysis/25.2.39/InstallArea/x86_64-el9-gcc13-opt/python/AnalysisAlgorithmsConfig/ConfigSequence.py", line 81, in makeAlgs
          block.makeAlgs (config)
        File "/atlas/strebler/HHbbtautau/EleTrig/build/x86_64-el9-gcc13-opt/python/EgammaAnalysisAlgorithms/ElectronAnalysisConfig.py", line 722, in makeAlgs
          raise RuntimeError("Failed to suggest electron map keys")
      RuntimeError: Failed to suggest electron map keys

      Investigating

  • :white_check_mark: CI Result SUCCESS (hash 303cd500)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Thomas Strebler
  • Tadej Novak added 3 commits

    added 3 commits

    Compare with previous version

  • Thomas Strebler resolved all threads

    resolved all threads

  • Tadej Novak marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 2 packages:

    • PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms
    • Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection

    Affected files list will not be printed in this case

    Adding @krumnack ,@tadej as watchers

  • :white_check_mark: CI Result SUCCESS (hash 0e697418)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Looks straightforward enough and discussed by the experts, approving for AR.

    Nils [Analysis RC]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading