Refactor Calorimeter to fix Coverity defects

Meisam Tabrizrequested to merge
mfarzali/athena:refactor into main

Fixes:

  • in Calorimeter/CaloLocalHadCalib/src/GetLCSinglePionsPerf.cxx

    • CID 17744: Use move instead of copy
    • Rewrite the logic according to CppCoreGuidelines ES.77: Minimize the use of break and continue in loops

  • in Calorimeter/CaloCalibHitRec/src/CaloCalibClusterDecoratorAlgorithm.cxx

  • in Calorimeter/CaloCnv/CaloSimEventTPCnv/src/CaloCalibrationHitContainerCnv_p4.cxx

Merge request reports