GeneratorObjectsTPCnv: Fix use of invalidated iterators.

Scott Snyderrequested to merge
ssnyder/athena:iter.GeneratorObjectsTPCnv-20250219 into main

Reverts previous incorrect change. Fixes test failures in the hepmc2 build.

Merge request reports