Fixes to copy dynamic content of MTJ

Tomasz Boldrequested to merge
tbold/athena:add-missing-copy-dynamic-in-mtj-test into main

This MR is an attempt to fix copyFrom to fully support dynamic content. That part actually work now.

However, what breaks now is related to how const MT is constructed form mutable MTJ. Namely in mutable MTJ we allocate storage backends in chunks. When constructing const MTJ we trim it, here: https://gitlab.cern.ch/atlas/athena/-/blob/main/Tracking/Acts/ActsEvent/Root/TrackContainerHandlesHelper.cxx#L84 in the ACTS test however plain copy constructor is called: https://github.com/acts-project/acts/blob/9cfe1898f8335ff94745cdf56862b0fc44e7d7cb/Core/include/Acts/EventData/detail/MultiTrajectoryTestsCommon.hpp#L902 Now I made the const MTJ to accept only "non const" (very fishy) mutable MTJ and trim it. However the next thing that is custom in xAOD MTJ is surfaces handling which at the moment can only be moved.

Does Mutable MTJ after construction of Const MTJ need to be ever usable? I believe having only move c-tor from Mutable > Const MTJ would solve issues.

Tagging @pagessin

Edited by Tomasz Bold

Merge request reports