Skip to content

Improve logic in GlobalChi2Fitter

Alexander J Pfleger requested to merge apfleger/athena:gx2f-logic into main

This PR makes the GX2F more readable by improving some logic:

  • use else if for mutual exclusive if-chains
  • consistently use && and || over and and or
  • use curly braces { } also for single expression ifs
  • use ternary assignment over int a = 0; if (b > 0) {a = b;}
  • avoid possible implicit conversion to bool when checking for nullptr
  • simplify nested ifs
  • avoid negations
Edited by Alexander J Pfleger

Merge request reports

Loading