TrigT2CaloCommon: fix memory leak in TrigCaloDataAccessSvc

Bertrand Martin Dit Latourrequested to merge
martindl/athena:24.0_TrigCaloLeak into 24.0

Hello,

This MR fixes a memory leak in TrigCaloDataAccessSvc found by valgrind (ATR-30983). In lateInit, there are about 250 cells created with new, but memory is not released in finalize prior to the deletion of cache->fullcont. In this MR, a vector is added to keep track of the position of these cells in the container, such that we can free memory in finalize. Valgrind confirms this fixes the memory leak. Note that there is no leak in the event loop.

Tagging @damazio .

Cheers, Bertrand

Merge request reports