AthLinks: Fix coverity warnings.

Scott Snyderrequested to merge
ssnyder/athena:cov.AthLinks-20250627 into main
  • Ignored return value (CID 10365, 10360)
  • Dead code (CID 10207)
  • Avoid potential overflow in unit test (CID 14731)

Merge request reports