Skip to content
Snippets Groups Projects
Commit b98c642e authored by Frank Winklmeier's avatar Frank Winklmeier
Browse files

Merge branch 'hasHelper.MuonIdHelpers-20191018' into 'master'

MuonIdHelpers: Add methods to test for the existence of subdetector helpers.

See merge request !27297
parents 25705b3b b6269d55
No related branches found
No related tags found
Loading
Loading
  • Hi @fwinkl, did you merge this in without a successful CI? Adding also @pboescho. We think that this cannot compile like it is (e.g. m_mdtIdHelper is not a member of MuonIdHelperTool.h. Best, Nico

  • Could just use the m_muonIdHelperSvc->hasCSC() etc methods for a quick fix

  • or just revert the merge, since the methods are never called anyway

  • Author Maintainer

    You are right, the release is broken: !27317 (merged)

    Strange, because the CI did succeed before the weekend. Anyhow, reverting this now.

  • yes, the reason is that !27297 (merged) was made with a nightly which still had the MuonIdHelperTool which was then migrated to a Service. Thus, now !27297 (merged) is not in sync with the Service anymore. So, reverting is fine.

  • Nicolas Koehler @nkoehler

    mentioned in merge request !27297 (merged)

    ·

    mentioned in merge request !27297 (merged)

    Toggle commit list
  • Author Maintainer

    Right, !27110 (merged) got merged just before !27297 (merged). And amazingly it didn't create a merge conflict.

  • Yes, it is quite surprising!

  • Owner

    Ouch. :-(

  • Frank Winklmeier @fwinkl

    mentioned in commit 97756ff5

    ·

    mentioned in commit 97756ff5

    Toggle commit list
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment