Skip to content
Snippets Groups Projects

Update the Ringer Hypo to MT framework

Merged Update the Ringer Hypo to MT framework
(removed):ringer_hypo_athenaMT into master
All threads resolved!
Merged Joao Victor Da Fonseca Pinto requested to merge (removed):ringer_hypo_athenaMT into master
All threads resolved!

This MR include the ringer hypo code to the MT framework thinking in all necessary features for run 3. The emulator code was updated since uses the ringer hypo. I included the ringer low energy flag here to be able for future studies.

The feature extraction (FEX) code ringer code will be included in another MR as requested by the review team.

Tagging @fernando , @thrynova and @wsfreund

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pavol Strizenec
  • Pavol Strizenec
  • Pavol Strizenec
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • Trigger/TrigAnalysis/TrigEgammaEmulationTool
    • Trigger/TrigHypothesis/TrigMultiVarHypo
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-21787-2019-03-12-00-13
    :warning: Athena: number of compilation errors 0, warnings 1
    :warning: AthSimulation: number of compilation errors 0, warnings 2
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 35238]

  • Timo Dreyer added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Joao Victor Da Fonseca Pinto added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • Trigger/TrigAnalysis/TrigEgammaEmulationTool
    • Trigger/TrigHypothesis/TrigMultiVarHypo
  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-21787-2019-03-15-07-05
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 35457]

  • Timo Dreyer removed 1 deleted label

    removed 1 deleted label

  • Timo Dreyer
    Timo Dreyer @tidreyer ·

    Removing redunant label.

    Timo (L1)

  • J
    Joao Victor Da Fonseca Pinto @jodafons ·
    Author Developer

    G4hive test failed. Not my fault.

  • Clara Nellist
    Clara Nellist @cnellist ·
    Developer

    Hi @jodafons and @grancagn. How should we proceed in this case? Cheers, Clara (L1)

  • Clara Nellist added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • G
    Sergio Grancagnolo @grancagn ·
    Developer

    Jenkins please retry a build

  • G
    Sergio Grancagnolo @grancagn ·
    Developer

    From Mattermost ( https://mattermost.web.cern.ch/atlassoftware/pl/anntj4uaipnozggu13mjgmjfoo ) it looks like the responsible MR !21932 (merged) is now merged, so it should not happen again.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • Trigger/TrigAnalysis/TrigEgammaEmulationTool
    • Trigger/TrigHypothesis/TrigMultiVarHypo
  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Clara Nellist
    Clara Nellist @cnellist ·
    Developer

    Super. Thanks, @grancagn. Clara (L1)

  • Clara Nellist
    Clara Nellist @cnellist ·
    Developer

    @jodafons, please note that the discussions should also be resolved before this can be approved. Clara (L1)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :o: :white_check_mark:
    required tests :o: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-21787-2019-03-18-20-40
    :o: Athena: number of compilation errors 1, warnings 2
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 35595]

  • Vakhtang Tsulaia
    Vakhtang Tsulaia @tsulaia ·
    Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • Trigger/TrigAnalysis/TrigEgammaEmulationTool
    • Trigger/TrigHypothesis/TrigMultiVarHypo
  • J
    Joao Victor Da Fonseca Pinto @jodafons ·
    Author Developer

    Hi, What discussion is still remain?

    Thanks a lot, joao :)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-21787-2019-03-19-06-40
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 35636]

  • Timo Dreyer resolved all discussions

    resolved all discussions

  • Timo Dreyer added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Vakhtang Tsulaia merged

    merged

  • Vakhtang Tsulaia mentioned in commit 688e3e19

    mentioned in commit 688e3e19

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

  • Tomasz Bold
    Tomasz Bold @tbold ·
    Developer

    Hi Joao, It seems you have not run the TrigUpgradeTest. This MR likely broke them. For the next MR please do run them.

  • Frank Winklmeier
    Frank Winklmeier @fwinkl ·
    Maintainer

    Just a note to shifter and RC: This one should have not been approved/merged as it introduced a new compiler warning. See the yellow exclamation mark in the CI results.

  • Sergio Grancagnolo mentioned in merge request !21931 (merged)

    mentioned in merge request !21931 (merged)

  • Tim Martin mentioned in merge request !22101 (closed)

    mentioned in merge request !22101 (closed)

  • Tim Martin
    Tim Martin @tamartin ·
    Developer

    Fixed on !22101 (closed)

    • Please register or sign in to reply