Skip to content
Snippets Groups Projects
Nils Erik Krumnack's avatar
Nils Erik Krumnack authored
define a ColumnarAnalysis project

This is my first attempt at creating a `ColumnarAnalysis` project.  It
is essentially a copy of the `AnalysisBase` project, but with a few
modifications:
* I went through all files and replaced `AnalysisBase` with
  `ColumnarAnalysis`.  Except for AnalysisBase externals, which I just
  left as is.  That is probably not the right thing to do, but it avoids
  having to update the externals definition as well.  Also, the externals
  don't compile at the UChicago Tier 3, so I have a hard time testing
  anything with it.
* I added a `COLUMNAR_ANALYSIS` cmake variable that can be used to turn
  off tests that don't work in columnar mode.  I'm not sure if I
  implemented this is the right way, but it seems to work.
* I set `COLUMNAR_DEFAULT_ACCESS_MODE` to 2, which should switch on the
  columnar implementation for all the tools.

I did try building this locally and it seemed to work, though I didn't
try running all the tests locally.  However, I ran enough tests to find
that ElectronEfficiencyCorrection tests needed to be disabled.

This probably needs a solid looking over by an ATLAS cmake expert, but I
hope this is at least a good starting point for discussions.
c5ca7da9
History
Code owners
Assign users and groups as approvers for specific file changes. Learn more.