Skip to content

Static checker updates.

Scott Snyder requested to merge ssnyder/atlasexternals:checkers-staticref-20190307 into master
  • Fix thread-safety check for static references:

We were generating a false positive for this:

const int* i1_create();
void i1() {
  static const int& r [[maybe_unused]] = *i1_create();
}

because the reference type itself isn't TREE_READONLY. But references don't take const qualifiers (they're in a sense implicitly const). Have the const check look at the target type of the reference rather than at the reference itself.

(Thanks to Frank W. for reporting.)

  • Don't warn about calls to clhep.

  • Remove support for gcc versions 7 and earlier. Now require gcc 8 or later.

Merge request reports