Skip to content

Static checker updates: Add TLS check, etc.

Scott Snyder requested to merge ssnyder/atlasexternals:checkers-20190520 into master

Static checker updates:

  • Add a new check to warn about cases where the EventContext is fetched from TLS when it is already available as a function argument.

    Many instances of this in Athena have already been fixed, but there are still likely to be some new warnings due to this. They are, however, usually quite straightforward and quick to fix, so let's move ahead with this.

  • Don't complain about unchecked calls to GeoModelKernel. Also fix an issue relating to finding the checker flag file for some directory layouts. (Won't affect the release, as this code is anyway disabled there.)

  • Update URLs in warning messages to point at the documentation as maintained in gitlab, rather than to the twiki page.

  • First step at migrating attributes from the gnu' to the ATLAS' scope. (Requires gcc 7+).

Merge request reports