Skip to content

GCC 8 / C++17 Fixes, 1.0 branch (2019.07.04.)

Attila Krasznahorkay requested to merge akraszna/atlasexternals:Gcc8Fixes-1.0-20190704 into 1.0

These are changes necessary to make it possible to build AnalysisBaseExternals using GCC 8 on CentOS7 in C++17 mode.

  • The XRootD update is a cherry-pick of the update I made for the master branch a while ago.
  • In order to get BAT-0.9.4.1 building, I had to introduce a new patch for it. Which removes the explicit declaration of possible exceptions coming from a few of the code's functions. (Which is a formalism not allowed with C++17 anymore.)
  • Once that was fixed, I had to realise that KLFitter was not correctly configured until now. 😦 It wasn't told explicitly which C++ standard to use for its build. Now I added that, which made the build in C++17 mode successful.

With all these update AnalysisBaseExternals is finally able to build every package (that it needs) for x86_64-centos7-gcc8-opt.

Merge request reports