Skip to content

GCC 8 Updates, 1.0 branch (2019.07.10.)

Attila Krasznahorkay requested to merge akraszna/atlasexternals:Gcc8Updates-1.0-20190710 into 1.0

This MR includes 2 non-essential, but definitely nice updates:

  • AtlasLCG now sets the GAUDI_CXX_STANDARD cache variable, to force the Gaudi build to use the correct C++ standard. The reason that this was not strictly speaking essential, is that previously Gaudi itself decided to use C++11, while CMake (through CMAKE_CXX_STANDARD) overruled that to C++17. This resulted in the compilation commands having both -std=c++11 and -std=c++17 elements in them. Out of which the latter one would prevail. With this update CMake and Gaudi should now be in agreement about which C++ standard to use.
  • FindGaudi.cmake was updated to treat all Gaudi headers, and externals included by the Gaudi headers, as "system headers". I.e. not to print warnings about them. This was necessary to suppress some annoying warnings with GCC 8 that come from the TBB headers.

As I began, the build was succeeding just fine without these two updates as well, but they definitely make the build a whole lot nicer.

Merge request reports