Skip to content

CMake Updates, master branch (2019.10.01.)

Attila Krasznahorkay requested to merge akraszna/atlasexternals:CMakeUpdates-master-20191001 into master

These are cherry-picks of various tweaks that I implemented in my development of akraszna/asyncgaudi, in the CUDATests-2.0.49-20190917 branch of my fork of this repository.

The updates are the following:

  • Added the PRIVATE keyword in setting up the linking of test executables. This was necessary to be able to nicely tweak the link options of these executables. (One can not mix "keyworded" and "non-keyworded" link declarations. And since we use these keywords everywhere else, it made sense to update test executables to this convention as well.)
  • Taught lcg_python_external_module(...) how to find locally installed python packages on my Ubuntu 18.04 machine. This is the one that I'm a little worried about. Hopefully it won't affect the nightlies. (It shouldn't... As long as a python module is provided by LCG, that should still be preferred in this setup...)
  • Added the OPTIONAL keyword to the install setup of the Python bytecode files. (Adding @fwinkl for information purposes on this...)
  • Fixed the usage of the OPTIONAL keyword in the installation setup of the libraries. See https://gitlab.kitware.com/cmake/cmake/issues/19775 for details on this issue. (Apparently it's an undocumented behaviour of the install(...) command...)

Merge request reports