Skip to content

macOS Fixes, master branch (2020.02.21.)

Attila Krasznahorkay requested to merge akraszna/atlasexternals:macOSUpdates-master-20200221 into master

Similar to !621 (merged), this MR is meant to get us further on the road to revive the macOS atlas/athena builds in the master branch. 😉

As it turns out Apple still doesn't support many of the same linker flags that "vanilla" Clang supports. So I made the checks a bit more rigorous for turning on these options by default.

At first I was thinking of turning these off for just the AnalysisBase project when building it on macOS, but in the end these flags are just missing with the "AppleClang" compiler all together. So we may as well just not use them ever with that compiler.

Pinging @krumnack. I still had to fix one thing in atlas/athena to get AnalysisBase compiled successfully from master on Mojave, but that will be in a separate MR, along with including !621 (merged) and this update. Though first athena!30437 (merged) should be merged in. (Hopefully it will be soon...)

Edited by Attila Krasznahorkay

Merge request reports