Skip to content

Ninja Dependency Generation Fix, master branch (2020.02.28.)

Attila Krasznahorkay requested to merge akraszna/atlasexternals:NinjaDepFix-master-20200228 into master

Now explicitly specifying to GCC and Clang that they are given a C++ header.

Without this flag Apple's Clang prints the following warning on every one of these invocations:

clang: warning: treating 'c-header' input as 'c++-header' when in C++ mode, this behavior is deprecated [-Wdeprecated]

Note that this would only show up when using Ninja as the build system, so it didn't show up in the CI or the nightlies (so far).

I cherry-picked this update from !625 (merged). The rest of that MR should also make its way into master eventually, it just seemed to make sense to fast-track this change ahead of everything else. 😉 Also, let's mention ATLINFR-2524 here as well. 😃

Merge request reports