Skip to content

AtlasHIP Improvements, master branch (2020.08.28.)

Attila Krasznahorkay requested to merge akraszna/atlasexternals:AtlasHIPImprovements-master-20200828 into master

As @fwinkl very rightfully pointed out in !718 (comment 3738813), the atlas_check_language(...) call was looking for the HIP compiler from scratch on every (re-)configuration of a project. Which is really not great for the WorkDir project of atlas/athena.

This is meant to fix that, by making atlas_check_language(...) resemble CMake's check_language(...) implementation a lot more than I originally wanted it to. (I was not a fan of making it a macro. But it does make sense to do it like this in the end...)

At the same time I made some other tiny quality of life improvements as well to the AtlasHIP code.

Merge request reports