Skip to content

Add a find module for pprof

Alaettin Serhan Mete requested to merge amete/atlasexternals:master-add-pprof into master

As I'm cleaning up code under Control/PerformanceMonitoring I came across a broken dependency. PerfMonGPerfTools seems to have a piece of code (aprof.py) that uses pprof to summarize the profiling results. But this doesn't seem to be installed in our nightlies because we don't explicitly ask for it.

From a quick look, I see LCG seems to install this, e.g.:

$ which pprof
/cvmfs/sft.cern.ch/lcg/views/LCG_98python3_ATLAS_2/x86_64-centos7-gcc8-opt/bin/pprof

So I thought we could perhaps add a basic find module, and simply do a find_package( pprof ) on the PerfMonGPerfTools side.

I should admit that I simply copied the logic form other modules (valgrind in particular). It's a simple CLI so we don't need to bring in any libraries etc.

Please let me know how it looks @akraszna as I'm not 100% sure on what's the best way to test this locally.

Many thanks 😄

Edited by Alaettin Serhan Mete

Merge request reports