Skip to content
Snippets Groups Projects

Implement Single Channel Power Supply Interface

Merged Karol Krizka requested to merge singlechannel into devel
All threads resolved!

Adds an abstract single channel power supply object that wraps around an IPowerSupply. It can either be initialized manually (by passing IPowerSupply and channel number to the constructor) or by using EquipConf.

The syntax for equipment configuration files is as follows. The input-hw.json example has been updated.

"channels": {
  "first-channel-name" : {
    "hw-type": "PS",
    "device": "PS name from hardware block",
    "channel" : #,
    "program": {
      /* potential programming */
    }
  },
  "second-channel-name" : {
    "hw-type": "PS",
    "device": "PS name from hardware block",
    "channel" : #,
    "program": {
      /* potential programming */
    }
  }
}

A few other changes that are an effect of this:

  • Remove some unused EquipConf member methods
  • EquipConf::getPowerSupply now connects/checks the power supply on first fetch
  • Rename hardware -> devices for the block where physical power supplies are declared
Edited by Karol Krizka

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Karol Krizka

      Hi @karol, @spagan,

      I have a question. With the code as it's at the moment, if one uses PowerSupplyChannel (that is the recommended approach for users), he/she will loose access to all the PS specific functions. How do we want to deal with it?

      Should we add any PS-specific function also to both IPowerSupply and PowerSupplyChannel?

      Thanks, Elisabetta

  • Karol Krizka added 3 commits

    added 3 commits

    • bb6cd3ee - Move powersupply from examples to tools.
    • 3a37fc49 - Example binaries are placed into examples directory.
    • dbabf248 - Add equipconf_singlechannel example.

    Compare with previous version

  • Karol Krizka added 1 commit

    added 1 commit

    • cc4d21b1 - Add channel/PS getters to PowerSupplyChannel.

    Compare with previous version

  • added 1 commit

    • 392e27c3 - change name to power-supply example, and add code snippet to access PS-specific functions

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • @epianori @spagan Any other comments?

  • Karol Krizka mentioned in merge request !60 (merged)

    mentioned in merge request !60 (merged)

  • I think it's all good! Simone

  • Karol Krizka resolved all threads

    resolved all threads

  • merged

  • mentioned in issue #8 (closed)

  • Please register or sign in to reply
    Loading