Improvements and bug fixes to PID resampling scripts
Improvements and bug fixes to PID resampling scripts
Motivation
A couple of bugs in current resampling spotted by @bldelane and @atully. In particular now correct:
- Use of the IsMuon version of the templates for proper DLLmu distributions
- Apply scaling of nTracks variable according to data/MC comparison studies performed by @atully on
B_c^+\to J/\psi \pi^+
. Use scale of 1.2 (1.4) Run 1 (Run 2) - Configure submission script to track jobs better. Give sensible and reproducible names and allow for simple resubmission. Will also check that output files have all the branches they need.
MR description
Described above.
How-to
README.md in PidResampling
already up-to-date
Clarity
Please provide an evaluation of the clarity level of the documentation and code (specifically, is the code commented? are the variables self-explanatory?). Please tick the level of clarity of code:
-
Bare: README.md
and alike are missing. The code is not very well documented. Please try to avoid merging if the code is in this state and spend some time documenting it; this will pay off in the long run. -
Acceptable: any other analyst should be able to understand what is being implemented by this MR with a couple of questions. Code has some comments and variables are reasonably named. -
Complete: README.md
exists, code is commented, headers are in place and variables are self-explanatory. I have spent time making sure that this is very clear and ready out of the box. This is the gold standard.
Checks
@bldelane has inspected distributions of corrected variables, which look reasonable. To be finalised, it needs checking with the B_c^+\to J/\psi \pi^+
mode by @atully
/cc @bldelane
Edited by Matthew William Kenzie