Skip to content

New Mask model

Nicolas Mounet requested to merge feature/refined_mask_model into feature/MonteCarlo

Old Mask class replaced by new MeasuredMask, with better exhale_efficiency model (using work of @mrognlie ). Hence removing _MaskBase and MeasuredMask.

This is on top of MR !184 (merged), to remove useless code and start fixing the tests with the new Mask model. It also fixes comments from https://gitlab.cern.ch/cara/cara/-/merge_requests/184#note_4520118 and https://gitlab.cern.ch/cara/cara/-/merge_requests/185#note_4520103

Diameter in exhale_efficiency is now in microns for improved readability (comment from @andrejh - https://gitlab.cern.ch/cara/cara/-/merge_requests/184#note_4522918)

Edited by Nicolas Mounet

Merge request reports