= symbol in value string of `BUILD_ARG` is mistakenly considered malformed
https://gitlab.cern.ch/ci-tools/docker-image-builder/blob/master/docker.go#L185-203
This part of the code somehow forbids the usage of =
in the BUILD_ARG
value string.
I believe this checks for the third =
does nothing but causes trouble to users.
Probably you can either
- Allow users to pass value string by wrapping them in double quotes and do proper escaping quotes check
- Don't even do such check and use something like
strings.SplitN(env, "=", 3)
instead, knowing that the second=
should be always followed by
Thank you for your time,
Yu-Heng