An error occurred while fetching the assigned milestone of the selected merge_request.
Fix missing ROOT version determination
All threads resolved!
All threads resolved!
Sorry, there are some another functions that uses RooFormulaVar::expression()
but does not take ROOT version into account.
Additional code improvement and bugfix are also implemented here. Note that the output of root-config --version
with latest ROOT is of the form X.YY.ZZ
(rather than X.YY/ZZ
), the root_checker.py
is also updated accordingly.
Edited by Yizhou Cai
Merge request reports
Activity
- Resolved by Yizhou Cai
Thanks @caiyi, the code does look a lot cleaner now. Though I think we could just create two functions to return the
formula_str
anddependents
of a RooFormulaVar. So that we don't need to write the version check every time we need them. Something likenamespace RooFormulaVarExt{ #if ROOT_VERSION_CODE < ROOT_VERSION(6,26,00) inline std::string getFormulaStr(RooFormulaVar& arg){ return arg.formula().formulaString(); } inline const RooArgSet getDependents(RooFormulaVar& arg){ return arg.formula().actualDependents(); } #else inline std::string getFormulaStr(RooFormulaVar& arg){ return arg.expression(); } inline const RooArgSet getDependents(RooFormulaVar& arg){ return arg.dependents(); } #endif }
Edited by Alkaid Cheng
assigned to @clcheng
requested review from @clcheng
mentioned in commit a7a89f63
Please register or sign in to reply