Improve error handling in Ntupliser trigger method for missing trigger names
The problem happens when we require a trigger that does not exist in the trigger menu
----- Begin Fatal Exception 03-Apr-2025 04:53:44 CEST-----------------------
An exception of category 'Ntupliser' occurred while
[0] Processing Event run: 306929 lumi: 115 event: 105988462 stream: 0
[1] Running path 'p'
[2] Calling method for module Ntupliser/'ntupliser'
Exception Message:
No dedicated collection exists for HLTriggerFinalPath
----- End Fatal Exception -------------------------------------------------
That is because each trigger menu ends with HLTriggerFinalPath
. if the p.triggerNames_[k]
we provide cannot be found, ntupliser will eventually check which collection HLTriggerFinalPath
should be. So we need a better error output.
With this change ntupliser will cout whole trigger menu when trigger can't be found.
eg:
----- Begin Fatal Exception 03-Apr-2025 06:03:10 CEST-----------------------
An exception of category 'Ntupliser' occurred while
[0] Processing Event run: 306929 lumi: 115 event: 105988462 stream: 0
[1] Running path 'p'
[2] Calling method for module Ntupliser/'ntupliser'
Exception Message:
HLT_PFJet40_v could not be found in the trigger menu:
HLTriggerFirstPath HLT_ZeroBias_Beamspot_v2 HLT_Physics_v7 DST_Physics_v7 HLT_Random_v3 HLT_ZeroBias_v6 HLT_HIL3Mu5_v1 HLT_HIL3Mu5_Track1_v1 HLT_HIL3Mu5_Track1_Jpsi_v1 HLT_HIDiPFJet25_FBEta3_NoCaloMatched_v1 HLT_HIDiPFJet15_FBEta3_NoCaloMatched_v1 HLT_HIDiPFJet25_NoCaloMatched_v1 HLT_HIDiPFJet15_NoCaloMatched_v1 HLT_HIDiPFJetAve35_HFJEC_v1 HLT_HIDiPFJetAve25_HFJEC_v1 HLT_HIDiPFJetAve15_HFJEC_v1 HLT_HIZeroBias_part0_v6 HLT_HIZeroBias_part1_v6 HLT_HIZeroBias_part2_v6 HLT_HIZeroBias_part3_v6 HLT_HIZeroBias_part4_v6 HLT_HIZeroBias_part5_v6 HLT_HIZeroBias_part6_v6 HLT_HIZeroBias_part7_v6 HLT_HIZeroBias_part8_v6 HLT_HIZeroBias_part9_v6 HLT_HIZeroBias_part10_v6 HLT_HIZeroBias_part11_v6 HLT_HIAK4PFJet15_v1 HLT_HIAK4PFJet40_v1 HLT_HIAK4PFJet60_v1 HLT_HIAK4PFJet80_v1 HLT_HIAK4PFJet40FWD_v1 HLT_HIAK4PFJet60FWD_v1 HLT_HIAK4PFJet80FWD_v1 HLT_HIPhoton20_HoverELoose_v1 HLT_HIPhoton30_HoverELoose_v1 HLT_HIPhoton40_HoverELoose_v1 HLT_HIPhoton50_HoverELoose_v1 HLT_HIPhoton60_HoverELoose_v1 HLT_HIEle15_WPLoose_Gsf_v1 HLT_HIEle20_WPLoose_Gsf_v1 HLT_HIEle30_WPLoose_Gsf_v1 HLT_HIEle40_WPLoose_Gsf_v1 HLT_HIEle20_eta2p1_WPTight_Gsf_CentralPFJet15_EleCleaned_v1 HLT_HIEle20_Ele12_CaloIdL_TrackIdL_IsoVL_DZ_v1 HLT_HIEle20_Ele12_CaloIdL_TrackIdL_IsoVL_v1 HLT_HIEle17_WPLoose_Gsf_v1 HLT_HIEle15_Ele8_CaloIdL_TrackIdL_IsoVL_v1 HLT_HIEle15_CaloIdL_TrackIdL_IsoVL_PFJet30_v1 HLT_HIMu17_v1 HLT_HIMu15_v1 HLT_HIMu12_v1 HLT_HIMu7p5_L2Mu2_Jpsi_v1 HLT_HIMu7p5_L2Mu2_Upsilon_v1 HLT_HIMu7p5_Track2_Jpsi_v1 HLT_HIMu7p5_Track2_Upsilon_v1 HLT_HIDimuon0_Jpsi_v1 HLT_HIDimuon0_Jpsi_NoVertexing_v1 HLT_HIDimuon0_Upsilon_NoVertexing_v1 HLT_HIPFJet25_v1 HLT_HIPFJet140_v1 HLT_HIPFJetFwd15_v1 HLT_HIPFJetFwd25_v1 HLT_HIPFJetFwd140_v1 HLT_HIAK8PFJetFwd15_v1 HLT_HIAK8PFJetFwd25_v1 HLT_HIAK8PFJetFwd40_v1 HLT_HIAK8PFJetFwd60_v1 HLT_HIAK8PFJetFwd80_v1 HLT_HIAK8PFJetFwd140_v1 HLT_HIAK8PFJet15_v1 HLT_HIAK8PFJet25_v1 HLT_HIAK8PFJet40_v1 HLT_HIAK8PFJet60_v1 HLT_HIAK8PFJet80_v1 HLT_HIAK8PFJet140_v1 HLT_EcalCalibration_v4 HLT_HcalCalibration_v5 AlCa_EcalPhiSym_v8 HLT_IsoTrackHB_v3 HLT_IsoTrackHE_v3 HLT_ZeroBias_FirstCollisionAfterAbortGap_v5 AlCa_LumiPixels_Random_v4 AlCa_LumiPixels_ZeroBias_v8 HLTriggerFinalPath
----- End Fatal Exception -------------------------------------------------
Merge request reports
Activity
I think it will help #176
Edited by Patrick Louis S Connorassigned to @zhye
requested review from @paconnor
added changepatch statusfinalising typephysics labels
mentioned in commit b70af5aa
mentioned in issue #176
Please register or sign in to reply