Skip to content

Draft: Bamboo feat jetmet correctionlib

Oguz Guzel requested to merge aguzel/bamboo:bamboo-feat-jetmet_correctionlib into master

Calculate jet met variations with json files and correctionlib.

Jet variations still lack smearing - it is available in the correctionlib but not in the json files. The remaining tasks are more or less the same as the MR opened for CMSJMECalculators here. These two MRs should work together.

Thanks for proposing changes! The checklist below may help to save time (feel free to remove this from the MR when done)

  • Is there a clear title, description of the changes, and motivation?
  • Has the bug, proposed new feature, or other change been discussed elsewhere before? Please provide a short summary in that case
  • Do the tests pass locally (including with the compiled backend, and the regression tests on a larger sample - details here)? Or did you do any other testing to verify that the changes are correct?
  • Did you consider adding a new test case covering the changes?
  • Is the documentation updated to reflect the modified behaviour of the code? (not applicable for bugfixes)
  • Are there changes that need to be added to the change log?
  • Is any impact on performance (when building the RDF graph or when running it) expected? Please provide an explanation why, for which use cases, and an estimate of the expected change.
Edited by Oguz Guzel

Merge request reports