Skip to content

Draft: Add support for new Ph2 ACF v6-19 thradj scan algorithm

The goal of this MR is to simply enable compatibility of module QC testing softwares with Ph2 ACF v6-19 new thradj scan algorithm.

Two new parameters were added ThrRelStart and ThrAmplitude (ultimately replacing ThrStart and ThrStop). Naively, ideal values for these parameters must be determined for every variation of the ThresholdAdjustment test.

At first, we can limit this to those tests used in module QC including:

  • 'ThresholdAdjustment_2000'
  • 'ThresholdAdjustment_1200'
  • 'ThresholdAdjustment_1000'
  • 'ThresholdAdjustment_950'
  • 'ThresholdAdjustment_900'
  • 'ThresholdAdjustment_850'

But ideally, this MR must cover all possible use cases, or remove them

  • 'ThresholdAdjustment_10000'
  • 'ThresholdAdjustment_6000'
  • 'ThresholdAdjustment_1500'
  • 'ThresholdAdjustment_Sparse'

The adjustment at 3000 electrons is a unique case, as it is currently suggested to be used in place of the initial 'PixelAlive' test and must also likely be considered:

  • 'ThresholdAdjustment_3000'

Then finally:

  • Remove ThrStart and ThrStop
Edited by Matthew Lewis Franks

Merge request reports

Loading