Skip to content
Snippets Groups Projects

Create script to analyze DAC scans

Merged Antonello Pellecchia requested to merge feature/dac-scans-analysis into main

Description

This MR adds an option to the gemos command that takes as an input the result of a DAC scan and creates an output file with the optimal DAC values to be set for each VFAT. Example of usage:

poetry run gemos analysis dac ~/daq/examples/gemdata/dacScan/fed1478-slot07.txt ~/daq/examples/results/dacScan/fed1478-slot07.cfg

Related Issue

How Has This Been Tested?

Tested on the result of DAC scan performed on a GE2/1 chamber.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Laurent Petre

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • c5322be8 - Change output file column names according to conventions

    Compare with previous version

  • added 2 commits

    • 78143a2c - Update command and parameter names, supoort multiple input files
    • 873365a7 - FIRST DRAFT Implement plotting

    Compare with previous version

  • added 1 commit

    • 46be56cc - FIRST DRAFT Implement plotting

    Compare with previous version

  • added 1 commit

    • b609e601 - Add plotting, fix DAC value choice

    Compare with previous version

  • Laurent Petre added 10 commits

    added 10 commits

    • b609e601...f07121f9 - 5 commits from branch main
    • 949a364c - Create script to analyze DAC scans
    • 4c61d621 - Apply calibration parameters before analyzing DAC scans
    • f89fe104 - Change output file column names according to conventions
    • 6197dbb0 - Update command and parameter names, supoort multiple input files
    • 895b34cb - Add plotting, fix DAC value choice

    Compare with previous version

  • assigned to @lpetre

  • assigned to @apellecc

  • Laurent Petre requested review from @lpetre and @cgalloni

    requested review from @lpetre and @cgalloni

  • Laurent Petre marked the checklist item New feature (non-breaking change which adds functionality) as completed

    marked the checklist item New feature (non-breaking change which adds functionality) as completed

  • Laurent Petre marked the checklist item All new and existing tests passed. as completed

    marked the checklist item All new and existing tests passed. as completed

  • Rebased! I'll update soon to match the new data formats.

  • Laurent Petre resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading