Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C cmsgemos-analysis
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 26
    • Issues 26
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cmsgemonline
  • gem-daq
  • cmsgemos-analysis
  • Merge requests
  • !26

Fix the DAC scan plotting of VFAT with warning

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Laurent Petre requested to merge bugfix/dac-scan-analysis into main Mar 04, 2022
  • Overview 0
  • Commits 2
  • Pipelines 2
  • Changes 1

Description

This MR fixes bugs encountered running on DAC scans from p5 with multiple problematic VFAT and missing scans, namely:

  • Fix a bug when the analysis was crashing if some VFAT from the layout tree weren't included in the scan.
  • Fix a bug leading to too many VFAT being plotted in "warning-only plotting" mode

Related Issue

How Has This Been Tested?

The code now runs on the most recent p5 dataset, plotting only the VFAT with warnings, without changing the result of the scan.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bugfix/dac-scan-analysis