Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C cmsgemos-analysis
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cmsgemonline
  • gem-daq
  • cmsgemos-analysis
  • Merge requests
  • !32

Add sanity check on VFAT config DB dump

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Daniel Estrada Acevedo requested to merge bugfix/sanity-on-vfatConfig-DB-dumb into main Apr 05, 2022
  • Overview 1
  • Commits 0
  • Pipelines 2
  • Changes 0

Description

The dump_database routine in vfat_calibratios.py produces from DB a DataFrame with a duplicate VFAT, this creates warnings downstream as in the case of issue #43 (closed).

Related Issue

Closes #41 (closed)

How Has This Been Tested?

I checked if the output file contained any duplicate line with

uniq -c output_file -d

Types of changes

I included a line of code to drop duplicates chips before writing the VFAT calibration parameters file.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited Apr 06, 2022 by Laurent Petre
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bugfix/sanity-on-vfatConfig-DB-dumb