Skip to content

Update the VFAT DB query to support the Phase-II schema

Laurent Petre requested to merge feature/phase-2-vfat-db into main


The title says it all. More details can be found in the commit message:

In order to include the new Phase-II VFAT3 plugin cards in the CMS DB a
new schema has been implemented in the CMS_GEM_MUON_VIEW.GEM_VFAT3_PROD_SUMMARY_V_RH
view. While it has the advantage of not modifying existing GE1/1 VFAT3
hybrids data, this change  creates additional complications in an
already messy database view.

This commit overhauls the VFAT DB query and sanitation function in order
to deal with the added complexity in the application logic code rather
than in the Oracle SQL query.

The GE1/1 entries are identical before and after this commit, modulo the
additional columns. The Phase-II entries match the expectations, based
on raw QC results files.

Related Issue

How Has This Been Tested?

Data can be fetched from the online DB and contains the correct information.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)


  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Laurent Petre

Merge request reports