Skip to content

Misc S-curves analysis enhancements

Camilla Galloni requested to merge feature/s-curves-enhancements into main


This MR mainly aims at fixing consistency problems between the labeled noisy channels and those seen in the boxplot graphs.

Additionally, multiple small improvements are included:

  • Record S-curve fit warnings in the output TTree
  • Copy the complete ROOT input file in the output file when the --full-output mode is selected
  • Allow choosing the IQR multiplicative factor used to identify noisy channels
  • Allow selecting whether or not to mask noisy and empty VFAT channels during the configuration generation

Related Issue

How Has This Been Tested?

Ensure that no more discrepancy is observed on P5 data which were previously problematic.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)


  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Laurent Petre

Merge request reports