Skip to content

Add S-curves based VFAT3 channel trimming features

Philip Thomas Templeman requested to merge feature/trimming-configuration into main

Description

Added a two-command process to do trimming (calculations based on Pieter's Jupyter notebook):

  1. gemos analyze trim [-h] [-t [TRIM ...]] [-s SIGMA] inputfiles [inputfiles ...] outputdir Takes results ROOT files from multiple scurve scans and uses a linear fit to determine config trimming values. Output to csv.
  2. [--arm_trim ARM_TRIMMING_FILES] [--zcc_trim ZCC_TRIMMING_FILES] arguments added to gemos create-config vfat. Trimming files are the csv output from step 1. Trimming values added bitwise to the VFAT_CHANNELS.CHANNELi register.

How Has This Been Tested?

Tested using the gemos poetry environment. Made new trimming configurations for the ME0 stack using the code, and trimming was applied correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Merge request reports