Skip to content

Take S-curve for channel 0

Camilla Galloni requested to merge feature/scurve into develop

Description

This MR includes some cleanup for the treatment of the calibration parameters, and of leftovers from the slice test treatment of the scans. This will have to be continued in future MR, which I'll split into more clear and fine commits.

Also there is the first attempt of an s-curve implementation for channel 0. however also this will have to be re-evaluated and find a better way to change the scan point; because the current implementation from the GEM supervisor is not practical.

The usage of the timer for the latency scan has been modified to be directly in the GEMSupervisor and no longer in the AMC13Manager, thus simplifying the soap calls due for the scan.

Related Issue

How Has This Been Tested?

in 904 on the coffin setup with calibration pulses scan, the latency is as expected Screen_Shot_2021-03-12_at_5.07.29_PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Laurent Petre

Merge request reports