Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C cmsgemos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 95
    • Issues 95
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cmsgemonline
  • gem-daq
  • cmsgemos
  • Merge requests
  • !111

Change xdaq tabs to bootstrap's nav-tabs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Dylan Oliver Teague requested to merge bugfix/tab-index-fix into develop Mar 08, 2021
  • Overview 5
  • Commits 4
  • Pipelines 4
  • Changes 4

Description

An issue that was found with xdaq in general is the indexing is not done in a nested way so nested tabs will sometimes not change if the tabs on different levels are in the same position. Since a push towards using more bootstrap is being tossed around, this MR simply changes how the AMC tabs for teh monitoring suite are held, namely using a nav-tabs object instead of the usual xdaq-tabs.

Related Issue

Closes #95 (closed)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bugfix/tab-index-fix