Fix array length for GE1/1 VFAT HDLC addresses
Compare changes
Files
2+ 2
− 1
@@ -122,11 +122,12 @@ void gem::hardware::amc::recover::operator()() const
This MR fixes a bug introduced in !188 (merged) that prevents configuration for a GE1/1 system with:
10 Sep 2021 13:02:38.850 [139906747725568] ERROR ch.cern.gem904daq04.p:20100.gem::managers::AMCManager.instance(147802) <> - caught std::exception: remote error: std::out_of_range: array::at: __n (which is 12) >= _Nm (which is 12)
Thanks for the report @cgalloni.
In more details, for GE1/1, the array with the default VFAT HDLC addresses was incorrectly set to a length of 12 instead of 24. Therefore, the loop over the VFAT was trying to access elements out-of-range. Extending the array to a length of 24 with the default addresses 0
.
Pending tests in on the GE1/1 integration setup in b904.