Skip to content

Prevent concurrent calls on the same xHAL connection

Laurent Petre requested to merge bugfix/concurrent-xhal-calls into main

Description

[Based on top of !207 (merged)]

From the commit message:

Until now, no mechanism was put in place to prevent concurrent calls on the same xHAL connection. If forwarded carelessly to the underlying networking layer, the calls can interleave and corrupt the buffers.

A mutex is introduced to serialize the RPC calls and fix the issue.

Related Issue

How Has This Been Tested?

Work seamlessly on the Phase-II test beam where the issue was first discovered and debugged.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Merge request reports