Skip to content

Fix the trigger links counters when the BXN offset is configured

Laurent Petre requested to merge bugfix/trigger-alignment into main

Description

This MR fixes to small issues (re-)discovered at p5 with the trigger links monitoring:

  • The BC0 misalignment counters are a precious tool to detect synchronization problems or trigger links issues
    • Monitor it!
  • If the BXN offset is changed in the OH FPGA firmware by a value not multiple than 4, the trigger link error marker counters max out
    • One needs to re-align the trigger links comma/bunch counter marker FSM via a link reset

Related Issue

How Has This Been Tested?

Working on the GE1/1 integration setup.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Merge request reports