Skip to content

Layout tree updates (GE1/1 long chamber in b904int-ge11 + GE2/1 demonstrator in cms)

Laurent Petre requested to merge feature/ge11-long-chamber-integration into main

Description

This MR first aims at adding the GE1/1 long chamber in the b904int-ge11 setup layout tree. As part of the layout tree updates, the GE2/1 demonstrator description has been added in the cms setup.

During the commissioning of the GE1/1 long chamber, two bugs have been found and are fixed here:

  • The GBT phase scan was never reporting as good as VFAT previously masked
  • The cached ADC transactions used in the DAC scans could lead to data corruption in parallel transactions

Related Issue

How Has This Been Tested?

  • The GE1/1 long chamber in the integration is now seamlessly commissioned
  • The GE2/1 demonstrator files were already tested at p5

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Laurent Petre

Merge request reports