Skip to content

Automatically mask OptoHybrids without any enabled VFATs

Laurent Petre requested to merge bugfix/automatic-oh-masking into main


Title says it all, more details in the commit message.

It could happen that the automatic VFAT masking was disabling all VFATs of a given OptoHybrid. The OptoHybrid itself was never removed from the input enable mask.

As a consequence, the per-chamber event builder was never producing any event (since no VFAT data was opening the event) and the per-AMC event builder was timing out on the given chamber.

When the L1A rate is high enough, this directly converts into deadtime.

The temporary solution, while waiting for a firmware fix, is to mask any Optohybrid in the input enable mask for which all VFATs are disabled.

Related Issue

How Has This Been Tested?

OptoHybrids successfully removed from the input enable mask on the GE1/1 integration setup.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)


  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Merge request reports