Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C cmsgemos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cmsgemonline
  • gem-daq
  • cmsgemos
  • Merge requests
  • !251

Convert Monitor tables into Vue.js Components

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Dylan Oliver Teague requested to merge feature/vue-js into main Apr 01, 2022
  • Overview 13
  • Commits 9
  • Pipelines 4
  • Changes 10

Description

As has been discussed in previous Issues and MRs, a more robust and modern web framework could help in code development and maintainability. This MR implements VueJS in the monitoring suite.

VueJS, along with components, allows for more automated html to be produced in self contained code snippets (with the .vue tag). These are notable for allowing individual styling and reuseability across the code base. As a proof of concept, the main monitoring tables in the monitoring suite have been split into 2 Vue objects defined in oh-table.vue and main-table.vue.

Currently the includes for the vue and vue component javascript are only the gemmonitor area, we may want to put these in the gemutils webDefault function so the api is visible to all projects

Also, because of the mixed javascript/html format of the vue files, if a linter is wanted, something more sophisticated might be needed.

Related Issue

Closes #128

This also is a new MR for !131 (closed). Because of the name change of DAQ -> FED as well as different framework (vue components) a new MR was thought to be prudent.

How Has This Been Tested?

The code has been run with the 904 setup and it reproduces the old table's results

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited Apr 01, 2022 by Dylan Oliver Teague
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/vue-js