Skip to content

Fix the GBT IC communication with firmware that report GBT IC errors

Laurent Petre requested to merge bugfix/failing-gbt-ic into main

Description

Based on top of !276 (merged) (to be merged first)

So far, the firmware was not reporting any error in case of failed GBT IC transactions. While this is technically a problem for the robustness of the system, no handling for this failure scenario was ever implemented in the software.

Now that the firmware does check and report the GBT IC errors, we must make sure not to go to error in such cases. The solution proposed here is temporary and consists in maintaining the current behavior. That is, the error is ignored and simply logged as a warning.

Better error handling and usage of the read feature are part of !274 (closed). The latter is actually the source of these few commits. While this MR could be pruned deeper, the commits implemented here are quite simple and provide nice additions to the software.

Related Issue

How Has This Been Tested?

Allow taking a run with v5.0.1-78-ge8734b6-new-format-tb which is impossible without this MR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Merge request reports