WIP: Refactor monitoring code base
Description
There is a monitoring page tab in all widgets that is unnecessary as the monitoring matures. This can be removed wholecloth from the gembase
to reduce code clutter. A large portion of the commits of this MR are devoted to moving pieces of code that are best suited for particular folders, eg gembase/src/GEMMonitor.cpp
isn't used much in the code (added as a friend class, but not utilized), so this code can be moved to gemmonitor
. This also means this code can just be added more directly to the Daqmonitoring code base.
To summarize the extend of this MR, the checklist shows the progress
-
remove gemmonitoring code from rest of codebase (WIP) -
put GEMMonitoring
class intogemmonitor
better
Related Issue
More details of this bug can be found in #53 (closed)
How Has This Been Tested?
The code has been tested by running in the XDAQ, initializing the various widgets, making sure nothing crashes unexpectedly
Types of changes
-
Bug fix (non-breaking change which fixes an issue) -
New feature (non-breaking change which adds functionality) -
Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
-
My code follows the code style of this project. -
My change requires a change to the documentation. -
I have updated the documentation accordingly. -
I have read the CONTRIBUTING document. -
I have added tests to cover my changes. -
All new and existing tests passed.