Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C cmsgemos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 95
    • Issues 95
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cmsgemonline
  • gem-daq
  • cmsgemos
  • Merge requests
  • !304

Draft: Bring ME0 to feature-parity

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Laurent Petre requested to merge feature/me0-parity into main Feb 13, 2023
  • Overview 2
  • Commits 14
  • Pipelines 7
  • Changes 27

Description

As the title says, this MR aims at bringing the ME0 station to feature-parity in cmsgemos. In particular, that means:

  • Implementing the S-bit rate scan (via the unified register hierarchy; see emu/0xbefe!143)
    • Update the recommended/supported firmware versions
  • Implementing the environmental parameters monitoring via lpGBT ADC readouts

Additionally, misc cleanups and improvements are introduced in this MR:

  • Introduction of the std::optional<T> in gemhardware (possible since the introduction of C++17)
  • Checking of the GBTx/lpGBT serial number in the gem-check-layout-tree tool
  • Avoidance of stalled data in the monitoring suite
    • Via the suppression of the magic 0xffffffff and 0xdeaddead values
  • Clean up of the lpGBT-specific functions

Related Issue

How Has This Been Tested?

  • GE1/1
  • GE2/1
  • ME0
    • Being used on the ME0 stack

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited Apr 18, 2023 by Laurent Petre
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/me0-parity