Skip to content

Install missing packages in CI

Laurent Petre requested to merge bugfix/missing-packages-in-ci into develop

Description

Python 3 was not installed in the CI. In the previous version of the packages, the CI passed because it was implicitly installed. This is no longer the case and requires an explicit Python 3 installation.

In addition, a version version of the MR lead to discover #82 (closed). The behavior in newer version of CMake (version 3.17) slightly changed and exposed an issue in FindxDAQ.cmake and FindCACTUS.cmake Fixing this issue as well. More information is available in the commit message.

Related Issue

Fixes #80 (closed) and #82 (closed).

How Has This Been Tested?

Waiting for the CI to fail, or, hopefully, pass...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Laurent Petre

Merge request reports