Add GE1/1 VFAT FEAST voltage monitoring (!322) · Merge requests · cmsgemonline / gem-daq / cmsgemos · GitLab

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption, please take a look at our documentation.

Laurent Petre requested to merge feature/ge11-vfat-voltages into main Nov 15, 2023

Description

The title should speak for itself.

Also includes various bug fixes or enhancements related to the SCA-based monitoring.

Ensure that the ADC conversions are over before retrieving the measurement, even in the case of an AXI bus error.
Make use of the 1kOhm precision resistor to calibrate the ADC current source (improve dramatically the PT100/PT1000 precision).
Export the raw ADC counts in the JSON monitorable object for debugging purposes.

Related Issue

None... 😕

How Has This Been Tested?

Thoroughly tested on the GE1/1 QC7 setup.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

Edited Nov 17, 2023 by Laurent Petre