Skip to content

Add default GBTx RX phases for all GE2/1 module types

Laurent Petre requested to merge feature/ge21-default-phases into main

Description

The title should speak for itself.

More than once, we got tricked because of a poor choice of default GBTx RX phase on GE2/1 when all phases were reported as good by the GBTx RX phase scan. This MR aims at fixing this issue once and for all.

The choice of those default phases is based on the aggregation of GE2/1 QC7 results with at least 5 modules per module type. The actual selection was made following the standard phase selection algorithm. In case of ambiguity in the selection of the best phase, the phase closest to the highest number was chosen (ideally, the phase most frequently good should be chosen, but it isn't immediately available). Also, note how some VFAT are always reported as bad on the M7 module type -- this is likely coming from a failed scan/module.

Click me to see the nice plots!

GBT_M1.png

GBT_M2.png

GBT_M3.png

GBT_M4.png

GBT_M5.png

GBT_M6.png

GBT_M7.png

GBT_M8.png

Related Issue

How Has This Been Tested?

Not strictly required as long as the code compiles... Time will tell if those phases were the best ones.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Merge request reports